Gareth Jones

Results 733 comments of Gareth Jones

@TooTallNate @EndangeredMassa any update on when this might be landed? I've now opened #11543 to track all the security vulnerabilities currently reported by using Vercel, which this will address a...

@justinretzolk I know you get a lot of PRs and have a lot of work on, but I'm conscious this relatively small PR has been around for a year and...

(I think we might also have a sort bug or two, but first I want to confirm if the test cases are actually valid since that'll be a huge source...

@hogo6002 I'm looking at picking this back up since it sounds like something we want overall? I think there's two main points: 1. I've switched to using `source.Name`, only caveat...

> For project scanning, I think we could also separate the table into multiple tables by ecosystem, similar to the [package table view](https://github.com/google/osv-scanner/blob/5462bdae82ee71e36bdc87e4c7fed6ce124f71b3/cmd/osv-scanner/__snapshots__/main_test.snap#L3176) > ... I think you might have...

After writing the above out, I dug back into the codebase and I think the answer is it's already been decided to sort by ecosystem first so feel free not...

> The best approach, I think, is to follow the [HTML output](https://hogo6002.github.io/v2/ubuntu/) method: group all sources from one ecosystem together but separate each source into individual tables. Personally I still...

Yeah [we were](https://github.com/google/osv-scanner/pull/889#issuecomment-2207815086) - is that something we still want to do? cc @another-rex fwiw, I don't think that's actually technically a breaking change but we might as well do...

@hogo6002 yeah it should be - I think this ended up falling off my radar between other work and then you were off for a week or so and then...

yeah oh that's right, for some reason now the table output is using wrong widths for columns so I need to figure out what's happening there - still @hogo6002 feel...