Jason Frey

Results 679 comments of Jason Frey

More generically, as described in #356, there should be a way to enable/disable any linter. Even *more* generically, this might be a subset of #246

Oh that's funky...it's like an infinite loop because there were @miq-bot commands in the initial issue comment to which it responds to itself, but the response is an error to...

@JPrause The sudden late reply is a known issue that we can't figure out... See related #335 #342

Would love to but I haven't been able to find an API for it

Similar to #347. I actually think the best way to handle comments is to not do our own transfer, but instead leverage the built-in GitHub transfer. Built-in doesn't handles labels,...

Any update? Lots of PRs are getting hammered with false positives...see https://github.com/ManageIQ/manageiq/pull/3140#issuecomment-112092908 as an example

Fixed by setting the .haml-lint values explicitly in https://github.com/ManageIQ/manageiq/pull/3166 @brandondunne We will need to put a copy on guides and do the symlink trick in deployment, but this should be...

high level I like the ability to use the github api status, but I'm not sure I want to block the PR expect in specific cases (like :bomb: :boom: :fire:...

Sorry, yes, red status. If too many PRs go "red" then it's harder for reviewers to differentiate between actual failed PRs (i.e. travis didn't pass) vs not actually failed PRs...

@europ I'm thinking the third case > No status (other offense types such as warning, informing, etc.) should still show the status API entry, but it should be a) green...