miq_bot icon indicating copy to clipboard operation
miq_bot copied to clipboard

haml-lint issues always show either warning or error

Open Fryguy opened this issue 10 years ago • 6 comments

  • Certain cops are being bucketed incorrectly. For example, "Line length too long" is coming up as a warning instead of a lower level severity. See https://github.com/ManageIQ/manageiq/pull/3126#issuecomment-111466039 for an example
  • On that same example, it shows line length max as 80, when the it should be 120. This implies it's not honoring the .haml-lint file properly.

@skateman Can you figure these out?

Fryguy avatar Jun 12 '15 13:06 Fryguy

Sure, this can be solved on the configuration file level, so please do not merge #67!

skateman avatar Jun 13 '15 06:06 skateman

Any update? Lots of PRs are getting hammered with false positives...see https://github.com/ManageIQ/manageiq/pull/3140#issuecomment-112092908 as an example

Fryguy avatar Jun 15 '15 15:06 Fryguy

https://github.com/ManageIQ/manageiq/pull/3166

skateman avatar Jun 15 '15 15:06 skateman

Fixed by setting the .haml-lint values explicitly in https://github.com/ManageIQ/manageiq/pull/3166

@brandondunne We will need to put a copy on guides and do the symlink trick in deployment, but this should be fine for manageiq itself.

Fryguy avatar Jun 15 '15 15:06 Fryguy

@Fryguy please reopen this issue! The severities are not fixed yet: https://github.com/brigade/haml-lint/issues/85

skateman avatar Jun 25 '15 14:06 skateman

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

miq-bot avatar Jun 11 '20 22:06 miq-bot