Anna Weine
Anna Weine
For now I solved it using these lines: #if defined(__has_include) #if __has_include("config.h") #include "config.h" #endif #endif If we don't want to remove config, it could be a way to go.
With these lines we have gcc-4.4 compiler also passes CI :)
> Interesting. But then are you compiling AVX or AVX2 code? How are you defining `HACL_CAN_COMPILE_VEC128`? By adding -DHACL_CAN_COMPILE_VEC128/256 to CFLAGS
I think Hacl_Hash* is expected, RSA PSS uses a hash function.
@polubelova the build system is not gonna regenerate the code itself in a day? Or you would like to compare the modifications?
Ok, gonna do.
As expected, the biggest difference is: ``` // new version uint8_t b[200U] = { 0U }; uint8_t *lastBlock = b; ``` versus ``` // old version KRML_CHECK_SIZE(sizeof (uint8_t), rateInBytes); uint8_t...
200 here is a number that is bigger than any possible rate (https://en.wikipedia.org/wiki/SHA-3, Instances section, there is a table. The table has rates in bits, the code uses the same,...
But I can indeed introduce a check inside absorb_last/absorb_inner functions, such that we accept any input and fail if it's less than 200.
