Anna Weine
Anna Weine
> Yeah, my mistake on the error. We should make the function return a Result. > > As for the other problem, there is a trick. I think. Give me...
@mxinden do you happen to know why I fail the CI? https://github.com/mozilla/neqo/actions/runs/15711244723/job/44269626849 for example.. [set_alpn](https://searchfox.org/mozilla-central/source/third_party/rust/neqo-transport/src/connection/mod.rs#558) seems absolutely ok
Ok, I seem to be left with only one red. @larseggert do you know how to improve the codecov?
> If you look at https://app.codecov.io/gh/mozilla/neqo/commit/b33d3240ab68200a1355c92edbe744efdfbc6ef8, the `agent.rs` accordion shows that the `encode` function has no test coverage. Everything else looks OK. I'm curious why, because I do have a...
> Are you sure it's testing _this_ encode function? Maybe add a +1 somewhere and see if the test still passes. I understood the problem. I've introduced a default encoding,...
> @Frosne There are a few open comments from @martinthomson; are you still planning any changes related to them? Otherwise, if you consider them resolved/addressed, please mark them as such....
Oh, hi. I am Anna, Firefox. I am curious if there is a simple way to test the patch when we implement it? I am not very familiar with SChannel.
As I mention in the bug, this week I am away, but I will try my best to look at the problem the next week. I think it's an NSS...
I will also definitely write DTLS tests on our side :)