Forgind
Forgind
@fanhaipeng, I reran it, and it passed. /cc: @dfederm for awareness on the flaky test.
Thanks @fanhaipeng!
@lifengl, @adrianvmsft, This change was for a perf issue arkalyanms raised a couple months ago. This change relies on the assumption that the GlobalProperties dictionary CPS accesses uses MSBuild's ProjImpl....
Can you provide details of what you did, what you expected, and what you saw? Was there any more information?
@BenVillalobos pointed out how I was being stupid with testing, and I verified this made the error go away 🙂
Thanks @JaynieBai!
I'm unclear on what the goal is here. Many of our logging helper methods call into our localized resources, so we couldn't do anything as clean as the example you...
@jaredpar, @masavani, @jmarolf [Build.txt](https://github.com/dotnet/msbuild/files/9758198/Build.txt) ^ Binlog (you'll have to convert it back from .txt) I got this by deleting the contents of all the PublicAPI.Shipped.txt files then trying to build....
> @BenVillalobos @Forgind what are the repo steps? I cloen MSBuild, do a build with the repo targeting .net 6 and then do another targeting .net7? > I got this...
@jmarolf, what's the status on this? Just want to make sure you have everything you need to continue investigating.