Forgind

Team triage: Looks like this hash isn't used a lot, so this probably isn't high priority.

> > … _plus_ OS, LOCALAPPDATA, and USERPROFILE. I don't know what made those special. > > Naively, aren't those properties almost always used in `msbuild` evaluation❔ For example, `UserProfile`...

I think you're right; this was just the viewer displaying things differently than I'd expected. I tried grabbing a diagnostic text log, and it looks good. I also tried replaying...

We're supposed to have arm64 bits on non-arm machines too, right? So then would this mean they wouldn't be ngen'd for that scenario? Is the decision here that arm64 bits...

@BenVillalobos, looks like you hit a missing optprof data issue. You presumably have to retarget where you're getting your data from the same way we did for main.

Before: ``` Build started 9/19/2022 4:33:23 PM. Attempting to cancel the build... Build FAILED. 0 Warning(s) 0 Error(s) ``` After: ``` Build started 9/19/2022 4:34:19 PM. Attempting to cancel the...

The failing tests made me concerned about having an assert here, and I am wondering whether I should really revert that part of this. Specifically, if you have a misauthored...

> About avoiding taking the lock. I wonder what happens if somebody would mix calls with and without disabling the change wave 17.4. It then may lead to errors and...

@MIchaelRShea, have you had a chance to look at BenVillalobos's comment?

@rokonec @AR-May @MichalPavlik, Flaky test was Microsoft.Build.Engine.UnitTests.MSBuildServer_Tests.CanShutdownServerProcess(byBuildManager: False) (on mac). I hit rerun. No need to investigate unless you see a pattern.