msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Support ItemDefinitionGroup in Choose/When

Open JaynieBai opened this issue 3 years ago • 2 comments

Fixes #5436

Context

Changes Made

There is a significant error in the original Constuctor ProjectItemDefinitionGroupElement(XmlElement xmlElement, ProjectRootElement parent, ProjectRootElement containingProject). The second parameter and third parameter types are the same. Fix the constructor bug and parse ItemDefinationGroup in when and otherwise.

Testing

Add one test SupportItemDefinationGroupInWhenOtherwise()

Notes

JaynieBai avatar Sep 16 '22 08:09 JaynieBai

CLA assistant check
All CLA requirements met.

dnfadmin avatar Sep 16 '22 08:09 dnfadmin

Hello, assuming the repo owners would like to take this change, they will ask for unit test coverage too.

danmoseley avatar Sep 16 '22 11:09 danmoseley

Thanks @JaynieBai!

Forgind avatar Oct 07 '22 14:10 Forgind