msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Fix issue 7828: enabling the binary logger adds console output

Open fanhaipeng opened this issue 3 years ago • 4 comments

Fixes #7828

Context

Binary logger option overrides verbosity by diagnostic and prints a line even verbosity is set to quiet.

Changes Made

The fix introduces a variable to store the original verbosity, if the "original verbosity" is quiet, it suppresses the console output when binary logger is requested.

Testing

Notes

fanhaipeng avatar Sep 20 '22 03:09 fanhaipeng

CLA assistant check
All CLA requirements met.

dnfadmin avatar Sep 21 '22 00:09 dnfadmin

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: fanhaipeng sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

dnfadmin avatar Sep 21 '22 00:09 dnfadmin

Hi @Forgind / @rainersigwald, the failed test case is from MultiplePlugins, should not be related to my change, what next step do you recommend? Thanks

Microsoft.Build.Engine.UnitTests.ProjectCache.ProjectCacheTests.MultiplePlugins System.IndexOutOfRangeException : Index was outside the bounds of the array.

fanhaipeng avatar Sep 21 '22 16:09 fanhaipeng

@fanhaipeng, I reran it, and it passed.

/cc: @dfederm for awareness on the flaky test.

Forgind avatar Sep 21 '22 19:09 Forgind

Thanks @fanhaipeng!

Forgind avatar Oct 07 '22 15:10 Forgind