msbuild
msbuild copied to clipboard
Fix issue 7828: enabling the binary logger adds console output
Fixes #7828
Context
Binary logger option overrides verbosity by diagnostic and prints a line even verbosity is set to quiet.
Changes Made
The fix introduces a variable to store the original verbosity, if the "original verbosity" is quiet, it suppresses the console output when binary logger is requested.
Testing
Notes
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
:x: fanhaipeng sign now
You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @Forgind / @rainersigwald, the failed test case is from MultiplePlugins, should not be related to my change, what next step do you recommend? Thanks
Microsoft.Build.Engine.UnitTests.ProjectCache.ProjectCacheTests.MultiplePlugins System.IndexOutOfRangeException : Index was outside the bounds of the array.
@fanhaipeng, I reran it, and it passed.
/cc: @dfederm for awareness on the flaky test.
Thanks @fanhaipeng!