Alexander Grund

Results 633 comments of Alexander Grund

> Is this included in new Easybuild v4.9.2? No, this is not even included in the develop branch yet. Otherwise the status on top of this page would say "Merged"...

This conflicts with https://github.com/easybuilders/easybuild-easyblocks/pull/3085 after that got merged possibly making all changes to the EasyBlock file unnecessary. Not fully sure though if there were any changes to the patterns that...

> Looks fine, but this should be tested a bit more broadly than just with GROMACS imho. GROMACS was used because that is where it fails without this. > I...

> @Flamefire Do we fully understand why what we have now fails with GROMACS? If so, can we document this somewhere (either in a dedicated issue, or in here)? This...

There just was an issue reported on Slack where OPENFOAM found a system Python: ``` CMake Error at /cluster/software/CMake/3.23.1-GCCcore-11.3.0/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Development.Module) (found suitable version...

I added #3026 for the 4.x branch to (only) show a well-visible warning and included that commit here upgrading it to an error in a 2nd commit (I guess you...

@boegel I added the requested opt-out option. I felt that a bool is not enough as we might want to still show a warning but not fail the build. Hence...

> @Flamefire Can you look into fixing merge conflict? Done. Was simply the `run_shell_cmd` change.

As for documenting "ERROR": We already have "defaults to aborting the build" and the default is ERROR so IMO this is already sufficiently documented. The alternative "'ERROR' (the default) aborts...

FYI: This found an actual issue for me: Python 3.11 moved from using configure args to env variables for TCL