Alexander Grund

Uff, ok. This was introduced in #1594 by @falbrechtskirchinger who might be more familiar with this part. My suspicion is that `GetRenderSize` shouldn't return a scaled render size but the...

The API looks good. Question is only how to get the UID. I guess as you only need them from within a campaign it would be great to not having...

That is exactly my point. The lua script would call `isFinished("world", 2)` not knowing it is modifying a potentially different campaign status

> No weird uid, no complicated stuff, only the campaign info available. I see trouble keeping that available when continuing a savegame. We currently store the gamestate with the map...

> The second make the mouse cursor move properly by scaling its position with the DPI, but that makes the buttons active area all wrong, and I can't see where...

Currently the name shown is that of the map as stored in the map file. Can you provide an example how this should look like in the mission file (i.e....

Thanks for the PR, looks good to me. I'd very much like to have a test case reproducing the bug first though. That would be best in https://github.com/Return-To-The-Roots/s25client/blob/master/tests/s25Main/integration/testPacts.cpp where you...

Are you willing to try and get a test working? If so I'd suggest the following thoughts: - Base your new test on `PactDurationTest` which already has code to make...

> When are these tests executed? During compilation? Compiling did work at least. You need to manually run them. When using make then `make test` will do that. In Visual...

> Thank you. Where do I run make test? I use the build setup for Windows like described in the readme.md Seems you are not using "make" but Visual Studio...