easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

fix finding of failed tests in output of PyTorch test step

Open boegel opened this issue 2 years ago • 4 comments

Test reports in https://github.com/easybuilders/easybuild-easyconfigs/pull/16286 and https://github.com/easybuilders/easybuild-easyconfigs/pull/16385 showed that installation was failing because no details were found on distributed/test_c10d_gloo and test_jit_cuda_fuser

That's fixed in this PR, and I've also fleshed out the code that extracts the details on the failing test suites/groups into a dedicated function, so we can test it in CI

@Flamefire Please take a look?

boegel avatar Jan 12 '23 19:01 boegel

@Flamefire suggested changes implemented and test enhanced, please take another look before I fire off test builds again with this?

boegel avatar Jan 13 '23 08:01 boegel

@Flamefire suggested changes implemented and test enhanced, please take another look before I fire off test builds again with this?

LGTM except for the failing check for the signaled test. Also I'd suggest to use the named tuple members in the easyblock, not just the test.

Flamefire avatar Jan 13 '23 09:01 Flamefire

@boegel @Flamefire Status on this one?

akesandgren avatar May 15 '24 06:05 akesandgren

This conflicts with https://github.com/easybuilders/easybuild-easyblocks/pull/3085 after that got merged possibly making all changes to the EasyBlock file unnecessary. Not fully sure though if there were any changes to the patterns that are not included yet.

I also have #3255 which further improves the function by pulling the last bits of the parsing out of the easyblock.

Flamefire avatar May 15 '24 07:05 Flamefire