Jeremiah Senkpiel comments

Results 518 comments of


                                            Jeremiah Senkpiel

Allow inferring enum variant types with `_::Variant` syntax

Pre-RFC up on the internals forum: https://internals.rust-lang.org/t/pre-rfc-inferred-enum-types/16100

Allow inferring enum variant types with `_::Variant` syntax

(if it wasn't clear: I gave up on this after the very large pushback on the internals forum, maybe someone can come at it with a better argument or angle.)

Remove Particle?

Hmmm, is particle any more efficient?

attempt-backport should ignore semver-major changes

Should be fairly easy to do, but a lot will slip by because they will be labeled by us later so I'm not 100% sure what to do about that....

attempt-backport should ignore semver-major changes

@TheAlphaNerd Think it might work better if we only added these labels once a PR is closed/merged?

attempt-backport should ignore semver-major changes

That does mean that people won't know if they'll need to adjust it until after though... :/ So IMO would be worse.

attempt-backport should ignore semver-major changes

@mscdex that is why https://github.com/nodejs/github-bot/pull/104 only removes it if the bot (last?) added it.

lts-watch-* labels should not be applied when dont-land-on-* exist

@mscdex do you have an example of this happening? I think in most cases it will not land cleanly then.

Removal of `Sync` bound on `ByteStream` makes interop with async-std hard

I will note also that aws_sdk_rust has their `ByteStream` be `Sync`: https://awslabs.github.io/aws-sdk-rust/aws_sdk_s3/struct.ByteStream.html#impl-Sync

Removal of `Sync` bound on `ByteStream` makes interop with async-std hard

I would also be perfectly ok with this being a compile time feature, fwiw.