Juan Farber comments

Results 6 comments of


                                            Juan Farber

[BCI-3989][core] - CR methods err when service unstarted

Still need to - Improve tests checking errors when calling the methods without the service started - Find a workaround and prevent the breaking change + multiple repo PR EDIT:...

[BCI-3989][core] - CR methods err when service unstarted

Refactored the structure of `EVMInterfaceTester` for clarity and to make the [proposed solution](https://github.com/smartcontractkit/chainlink-common/pull/705#discussion_r1761094885) work: - `Setup` receives the `started` flag to check if we should return CR started - `Setup`...

[BCI-3730] - Remove dependence on MinConfirmations in EVM TXM code

Handing off WIP to @huangzhen1997

[BCI-3988] - FilteredLogs receive []Expression instead of whole KeyFilter

@patrick-dowell > What impact will this PR have on CCIP? Just want to make sure we are mindful of the concerns Makram raised. My other comments were mostly questions as...

initial ideation of chain agnostic modifier

todo: clean remaining logs after testing

[BCFR-147][core] - Add codec chain agnostic modifier for converting byte array address to string

needs https://github.com/smartcontractkit/chainlink/pull/14741