chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

[BCI-3730] - Remove dependence on MinConfirmations in EVM TXM code

Open Farber98 opened this issue 1 year ago • 3 comments

Description

Parts of the EVM TXM code still relies on MinConfirmations regardless if the chain is enabled to use finality tags. Through this PR we are updating the code to utilize the head tracker’s latest finalized block instead of MinConfirmations.

Acceptance Criteria

  • All direct references to MinConfirmations should be removed to enable the use of finality tags.
  • Remove all instances of MinConfirmations from the EVM TXM code

Tickets:

Relates to:

  • https://github.com/smartcontractkit/chainlink/pull/13638
  • https://github.com/smartcontractkit/chainlink/pull/13794

Unblocks:

Farber98 avatar Jul 31 '24 13:07 Farber98

Handing off WIP to @huangzhen1997

Farber98 avatar Jul 31 '24 15:07 Farber98

Need to fix integration test TestIntegration_AsyncEthTx

huangzhen1997 avatar Aug 09 '24 04:08 huangzhen1997

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

cl-sonarqube-production[bot] avatar Sep 03 '24 18:09 cl-sonarqube-production[bot]