[BCFR-147][core] - Add codec chain agnostic modifier for converting byte array address to string
Description
This PR introduces the AddressBytesToStringModifierConfig modifier and modifies the contract to include a new field for testing purposes. Heads up that we will inject this modifier and skip its JSON serialization.
Resources
Related PRs
- https://github.com/smartcontractkit/chainlink-common/pull/818
- https://github.com/smartcontractkit/chainlink-solana/pull/875
Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.
WF: CI Core#cd1f549
1. HTTP 503 Service Temporarily Unavailable error during push request:[Flakey Test Detection]
Source of Error:
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2201121Z 2024/10/16 11:07:51 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2203345Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2204561Z <body>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2205615Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2206825Z <hr><center>nginx</center>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2207546Z </body>
Flakey Test Detection Re-run tests 2024-10-16T11:07:51.2208058Z </html>
Why: The error occurred because the server handling the push request was temporarily unable to handle the request, possibly due to maintenance or overload.
Suggested fix: Retry the request after a brief wait or investigate server status and load to ensure it can handle incoming requests.
Solidity Review Jira issue
Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.
This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Please reach out to the Test Tooling team and notify them about any issues you encounter.
Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/happy-planets-accept.md
This PR has been linked to Solidity Review Jira issue: BCFR-957
AER Report: CI Core ran successfully :white_check_mark:
AER Report: Operator UI CI ran successfully :white_check_mark:
needs https://github.com/smartcontractkit/chainlink/pull/14741
Quality Gate passed
Issues
2 New issues
0 Fixed issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
3.3% Duplication on New Code