FabijanC

Results 63 comments of FabijanC

@vibenedict description updated

@vibenedict To avoid confusion, your task is this one. Saying this because you also applied for #130, but that one had another applicant, and since you are the only applicant...

E.g. `starknet_call` is tested in https://github.com/0xSpaceShard/starknet-devnet-rs/blob/ed53233079c9dc338ea432d18e2eeb4e43ab85b2/crates/starknet-devnet/tests/test_call.rs#L28. Would be cool to test the case where there are e.g. 3 blocks, and you want to call with block_id being number 2. Also...

@mikiw I think you might be after something with that last idea: ![image](https://github.com/0xSpaceShard/starknet-devnet-rs/assets/28579396/fc76500b-7586-4d7e-8d2a-a01f8f625393)

While minding my own business, I was digging through the code and had some ideas about this issue. - I saw that we clone the state in several places (look...

@sgc-code hey, do you need old state history? Like, being able to query old states with an old block_id?

@sgc-code Sure we are also considering more efficient storage options, but were just considering conditional disabling of state storing as the quickest fix. Thanks for the reply

I suspect the largest part of the state history are contract classes. As has already been mentioned somewhere, storing a clone of state (together with declared classes) for each block...

You don't have to address those TODO comments that are covered by other GitHub issues, so make sure to first search the [issue list](https://github.com/0xSpaceShard/starknet-devnet-rs/issues). E.g. this issue: https://github.com/0xSpaceShard/starknet-devnet-rs/issues/192

@TobieTom You've been assigned.