FabijanC comments

Results 99 comments of


                                            FabijanC

Enable custom account in deploying L1-L2 messaging contract

@coderabbitai review

Provide an endpoint, for Rivet, to restart devnet in forking mode

Duplicate of #504

Forking at old block should be better tested

Are you sure this isn't already tested? Also note I made a small (but important) fix to the issue description.

Forking at old block should be better tested

It would need to be similar to `test_deploying_on_origin_calling_on_fork`, with an extra block on origin that contains a tx that modifies the contract, but with forking done before that block. Assigning...

Forking at old block should be better tested

@Abeeujah Assigning you

Apply prettier, upgrade Node, add PR template

Thanks for the review @amanusk! I'm ok with this being the last PR of 0.8.0 The formatting is already applied, I didn't get any new changes besides the ones resulting...

Investigate slow response time on fork tests

A few thoughts: 1. It would make sense to compare how this performs on an unforked Devnet. - Would allow seeing how much the forking itself contributes to the slowdown....

Deploying a messaging L1-L2 contract should be doable using a custom account

@nagxsan How exactly would you modify the API?

Deploying a messaging L1-L2 contract should be doable using a custom account

Sounds promising. We could default to the first pre-funded account if no key specified. Would just specifying `private_key` be enough? Would the address need to be specified? Regarding testing, I...

Forking could rely on caching

Hey! For now - no