starknet-devnet-rs icon indicating copy to clipboard operation
starknet-devnet-rs copied to clipboard

Published 20 hours ago • verified publisher icon 0xSpaceShard

TODO comments for removal

Open marioiordanov opened this issue 1 year ago • 19 comments

There are some TODO comments, that either can be resolved or removed.

marioiordanov avatar Jan 30 '24 14:01 marioiordanov

@g4titan hi! Any progress?

ivpavici avatar Mar 11 '24 15:03 ivpavici

Let me know if i can help on this one :)

Gerson2102 avatar Apr 22 '24 02:04 Gerson2102

Hello @ivpavici I would love to be part of this effort! 👷🏽‍♂️, thanks (I am in OD Hack telegram, ready to start on Monday 🫡)

PabloVillaplana avatar Apr 22 '24 04:04 PabloVillaplana

Hi @mikiw and @ivpavici Let me know if there is any opportunity to contribute to this issue. 👀

PabloVillaplana avatar Apr 22 '24 06:04 PabloVillaplana

Hi @PabloVillaplana , @Gerson2102 applied first so I will assign him, if no progress is reported in the next 2 days you can get it!

ivpavici avatar Apr 22 '24 09:04 ivpavici

You don't have to address those TODO comments that are covered by other GitHub issues, so make sure to first search the issue list.

E.g. this issue: https://github.com/0xSpaceShard/starknet-devnet-rs/issues/192

FabijanC avatar Apr 22 '24 11:04 FabijanC

You don't have to address those TODO comments that are covered by other GitHub issues, so make sure to first search the issue list.

E.g. this issue: #192

Got it!

Gerson2102 avatar Apr 22 '24 12:04 Gerson2102

@EmmanuelAR hi! you can! good luck!

ivpavici avatar Aug 13 '24 07:08 ivpavici

Hi @ivpavici ,

I hope you’re doing well. I wanted to let you know that, due to some personal issues, I won’t be able to complete the task assigned to me. I really appreciate the opportunity and I’m sorry for any inconvenience this may cause.

Thank you for your understanding and support.

EmmanuelAR avatar Aug 22 '24 15:08 EmmanuelAR

Hola. I'm Tobias and I would love to take over this particular issue. I am quite new to the space but I have already contributed to some projects and recently learned Cairo and Rust

TobieTom avatar Feb 11 '25 23:02 TobieTom

@TobieTom You've been assigned.

FabijanC avatar Feb 12 '25 08:02 FabijanC

@TobieTom You've been assigned.

alright. will get to work

TobieTom avatar Feb 12 '25 23:02 TobieTom

@TobieTom Any feedback? Or should we unassign you?

EDIT: Unassigning due to unresponsiveness.

FabijanC avatar Feb 25 '25 08:02 FabijanC

any update on this? I'd love to work on this project @FabijanC

Nanle100 avatar Mar 10 '25 11:03 Nanle100

@Nanle100 You've been assigned

FabijanC avatar Mar 10 '25 12:03 FabijanC

reading the first comment "There are some TODO comments, that either can be resolved or removed." I noticed there are couple of TODOs. Am i to fix every one of them or their is a specific one to be resolved? @FabijanC

Nanle100 avatar Mar 10 '25 12:03 Nanle100

Fix as many as possible

FabijanC avatar Mar 10 '25 12:03 FabijanC

sharp! @FabijanC

Nanle100 avatar Mar 10 '25 12:03 Nanle100

i made my first pull request, please review code @FabijanC

Nanle100 avatar Mar 10 '25 14:03 Nanle100