John Ericson

Results 906 comments of John Ericson

@L-as Edited the description to be precise about it.

Added the commit that @haenoe contributed, thanks!

Oh lovely, I don't think I got that eval error locally with Nix 2.18.

I wonder if the problem https://github.com/NixOS/nix/pull/11257 is fixing is at all related.

I like this. Can we get a release note written?

This didn't work in the past to your knowledge did it? (Just trying to understand is this, strictly speaking, a feature request or a regression.)

Thanks! I think we always do `asserts`, but this is still better. (Indeed, always doing `asserts` is a work-around for mistakes like this.)

OK got your last two things, @xokdvium

@philipwilk nice work! One small thing, instead of checking whether we're at the end of iterators, I rather you just save the last exception. (You an do this with `std::move`...