John Ericson

Results 562 comments of John Ericson

There's two branches being discussed here, the PR and the other one. Which is preferred? I am not sure I've encountered `tools.nix` yet -- so I am not really sure...

> The fetchGit function is capable of making the decision itself (i.e. ref = null;). Yeah the remote-side HEAD symref is the gold standard here.

@FintanH try using strace to get the underlying `cargo metadata` command? This might be an issue for upstream.

Try running that command without network access? I bet it's trying to download stuff to make a lock file on the fly.

You do fundamentally need a lockfile to use crate2nix. Without one there is not *concrete* buildplans, just some constraints. crate2nix doesn't want to duplicate Cargo in learning how to satisfy...

Yes the fact of the matter is you want to keep 1 or more Cargo.locks that don't go to `crates.io` when the library is published, but are used for CI....

(See https://github.com/kolloch/crate2nix/issues/205#issuecomment-941199516)

@QAston sorry I didn't respond sooner, are you saying this fix is insufficient on its own?

#203 and #212 need tests, but it's unfortunately a bit tricky to make some that are not slow.

I think the macOS issue is spurious.