John Ericson

Results 944 comments of John Ericson

Sorry, but are you vibe coding this? I bunch of other stuff changed in this revision that seems orthogonal to what I requested.

OK thanks. So I would prefer to do all HTTP status logic in a separate PR, even if the state machine logic is not so useful on its own. Is...

Ah now that I finished revieweing, I feel better too. Sorry about that --- I think we just had a misunderstanding about what exactly I meant with these loops, and...

@philipwilk Thank so much! Last thing is can you put more information in the commit message? (We want the history to be meaningful without GitHub access, though that said, you...

Actually, maybe I can fix up myself with a squash merge.

I like separate library, non-plugin, as a way to still support statically-linked Nix, but moving us in the right direction.

Thanks to talking to @puckipedia, I became satisfied that the other way of changing the abstract syntax (pair of env and optional structured attrs) wasn't "too lax" because there already...

Notes from today's Nix team meeting: - What about perf of parsing the structured attrs eagerly? - @mic92 can check, perhaps - What about derivations that no longer parse during...

I turns out the reading derivation issue we were worried out just occurs with CA derivations #13575. Furthermore, an existing plan quite orthogonal to this PR solves the problem ---...

`nix derivation` should be store-layer only. However, this could technically pass if the idea is that store-layer commands still get transparently "upgraded" in full Nix into talking "full" installables and...