Hileb

Results 36 comments of Hileb

>You don't need to call net.minecraftforge.common.MinecraftForge.EVENT_BUS.post in Forge code, just import it (doing so in vanilla patches is fine) This part may have belonged to the patch before. It is...

>I am not sure if we should break this before release, need further discussion We can also handle it separately without break it?

> I noticed that you are modifying GuiScreen, how's this change's compatibility to current mod? I only modified the part that handles HoverEvent and ClickEvent. In theory, there will be...

> Deleting Lucky Block is useless. I hope to check the code in Cleanroom because the Forge loader will not encounter this issue under the same mod (of course, Forge...

> The icon looks bad (due to its rough edges), I will recommend using the original icon, but with corners rounded Yes, I don't have the original image of it....

### Icon Forge Installer do not support scaling for image. I make a version of 64. (forge's is 256x64) ![image](https://github.com/CleanroomMC/Cleanroom/assets/107909747/feb41b87-e6e8-4050-9101-0d34d2bf70b2) And use image of 64 make installer smaller than image...

change to neoforge installer ![image](https://github.com/user-attachments/assets/034b976e-c92a-4418-b203-d195c94bc88b) but the field of icon is invalid, use https://github.com/neoforged/LegacyInstaller/blob/main/src/main/java/net/minecraftforge/installer/ui/Images.java#L31 TODO: find out how to replace it