Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard
verified publisher icon CleanroomMC

[3228]Enable the openGui data longer than 128 bits

Open Ecdcaeb opened this issue 1 year ago • 3 comments

warning! break the network compat with old forge server/client. https://github.com/MinecraftForge/MinecraftForge/issues/3228

Ecdcaeb avatar Feb 16 '24 03:02 Ecdcaeb

Two problem:

  • You don't need to call net.minecraftforge.common.MinecraftForge.EVENT_BUS.post in Forge code, just import it (doing so in vanilla patches is fine)
  • I am not sure if we should break this before release, need further discussion

kappa-maintainer avatar Feb 16 '24 03:02 kappa-maintainer

You don't need to call net.minecraftforge.common.MinecraftForge.EVENT_BUS.post in Forge code, just import it (doing so in vanilla patches is fine)

This part may have belonged to the patch before. It is not a part of FMLNetworkHandler. https://github.com/MinecraftForge/FML/blob/master/src/main/java/net/minecraftforge/fml/common/network/internal/FMLNetworkHandler.java#L92

Ecdcaeb avatar Feb 17 '24 06:02 Ecdcaeb

I am not sure if we should break this before release, need further discussion

We can also handle it separately without break it?

Ecdcaeb avatar Feb 17 '24 07:02 Ecdcaeb