CleanroomMC
Fix extra_files and icon for installer
Why this pr here
The existing installer is missing the licenses! The existing installer icon is incorrect!
What this pr brings
Fix Extra Files
Forge
Cleanroom 3029
This PR
url is not imported by this pr.
Icon
from twitter, remove the background to adapt the install theme.
The icon looks bad (due to its rough edges), I will recommend using the original icon, but with corners rounded
The icon looks bad (due to its rough edges), I will recommend using the original icon, but with corners rounded
Yes, I don't have the original image of it. I will ask rong for the original image or process it carefully.
The icon looks bad (due to its rough edges), I will recommend using the original icon, but with corners rounded
Yes, I don't have the original image of it. I will ask rong for the original image or process it carefully.
Use this one, I believe an icon is enough, the text "Cleanroom" can be left out.
Icon
Forge Installer do not support scaling for image. I make a version of 64. (forge's is 256x64)
And use image of 64 make installer smaller than image of 512
Title
it is hard coded. Sorry ;( https://github.com/MinecraftForge/Installer/blob/2.0/src/main/java/net/minecraftforge/installer/InstallerPanel.java#L258
change to neoforge installer
but the field of icon is invalid, use https://github.com/neoforged/LegacyInstaller/blob/main/src/main/java/net/minecraftforge/installer/ui/Images.java#L31
TODO: find out how to replace it
due to https://github.com/neoforged/LegacyInstaller/pull/34#issuecomment-2425937887
I have done my best. Use it? Fork it?
Ready for rewiew
Is there a reason why NeoForge's installer tools is used instead?
1.support custom title 2.i10n 3.More support will be available. The MinecraftForge Installer is updated slowly.
I don't think there is much change on NeoForge fork to consider switching since most of features already completed. If the later development of CRL required a change on Installer, we will consider switch or create new one instead.
I don't think there is much change on NeoForge fork to consider switching since most of features already completed. If the later development of CRL required a change on Installer, we will consider switch or create new one instead.
This PR has been stagnant for a while, and LegacyInstaller can do all my needs. With my meager wisdom, I can't foresee the disadvantages here. I can only see the benefits of the conversion and the pleasing new features, while I can't understand why this change is unpleasant.
Done.
Seem good, just move the icons to separate folder and I will check out for merging.
1.12.2 lacks official mapping, which will cause an exception when making an offline fat installer containing the mc body. https://github.com/neoforged/LegacyInstaller/blob/f4d8f3fae5e0497732dac454232aeac70dabb786/src/main/java/net/minecraftforge/installer/actions/FatInstallerAction.java#L65
external use of the installer is not really a supported use case
(this is related to your other issue too)
fork it if you want to use it and need changes
If this needs to be solved, although it is not commonly used, then a fork is needed.