Edoardo Zoni
Edoardo Zoni
I think we can just vote, I'm not sure we need to discuss. I'll try to poll the TC either here or on Slack sometime soon!
Hm, this seems to run into the following warning that may be unavoidable, as it is related to a preprocessor directive that is in place for PISCAR (`#define PXRMP_WITH_GPU`): ```console...
This may be the right place to look at: https://github.com/BLAST-WarpX/warpx/blob/c5b8a512cde594b052b3a4c3b3a0faaeffc9bd8b/Docs/Doxyfile#L2280-L2307
I think one chance we have is to run the analysis separately for each geometry and also wrap the docstring that are specific to a given geometry in ~~a preprocessor...
The ```bash ./.github/workflows/source/doxygen WARPX_DIM_1D_Z ``` still fails with ``` /home/runner/work/warpx/warpx/Source/BoundaryConditions/PEC_Insulator.H:76: error: argument 'set_F_y_lo' of command @param is not found in the argument list of PEC_Insulator::ApplyPEC_InsulatortoField(std::array< amrex::MultiFab *, 3 > field,...
Basically the goal here will be to have the analysis of the test `test_2d_collisions_split_position_push_electromagnetic` pass without breaking any other tests, with respect to this CI reference starting point: https://dev.azure.com/BLAST-WarpX/WarpX/_build/results?buildId=2275.
Discussed with @oshapoval offline: - The momenta that are averaged should be the momentum at the end of the first position half-push and the momentum after the collisions. - The...
@RemiLehe @oshapoval I start requesting your review in case you have comments on the early draft. I don't think it's working correctly yet.
The only CI test that crashes runtime after [648020d](https://github.com/BLAST-WarpX/warpx/pull/6275/commits/648020d4445392ff605eac877c1f8aabe4765739) is `test_1d_photoneutralization_dsmc`.
@atmyers I have some local code changes that I think do what we discussed, but I am stuck on one point. I think I would have to pass the `ux_avg`,...