Edoardo Zoni

Results 177 comments of Edoardo Zoni

Coming back to this, I built and installed against a local copy of https://github.com/spack/spack-packages, following the instructions at https://spack.readthedocs.io/en/latest/packaging_guide.html#setting-up-for-package-development. In my local copy, I modified https://github.com/spack/spack-packages/blob/develop/repos/spack_repo/builtin/packages/warpx/package.py by adding some debugging...

Note that we will merge #5247 first, so there will be probably a few more conflicts to fix.

Thanks, @WeiqunZhang. I guess we can try this on WarpX too, although, if really it isn't feasible to wait until the `paths-ignore` filter is fixed on the GitHub end, I...

Copied from https://github.com/ECP-WarpX/WarpX/issues/5205#issuecomment-2330147687 because it is relevant here as well: > To generalize the analysis scripts, we could change the APIs of the tolerance argument to the checksum API, and...

@ax3l I guess I would go for multiple arguments, say - `rtol_single_portable` (default: `...`) - `rtol_double_portable` (default: `...`) - `rtol_double_machine_precision` (default `...`) because I don't see a good way to...

Discussed with @RemiLehe offline: The functions `get_mr_levels` and `get_mr_levels_alldirs` fails _by definition_ when we call it on coarse-patch MultiFabs, e.g., `current_cp`, because those are allocated only on levels greater than...

@ax3l @RemiLehe Just a heads-up, I rebased and pushed a few more fixes and this might be almost ready. Let's see the latest CI status after the last commit and...

This is the only CI failure left after [fb0dc3c](https://github.com/ECP-WarpX/WarpX/pull/5356/commits/fb0dc3c83c62b5c799cf8891ce51bcaeb2a18186): ``` The following tests FAILED: 417 - test_3d_effective_potential_electrostatic_picmi.run (Failed) 418 - test_3d_effective_potential_electrostatic_picmi.analysis (Failed) 419 - test_3d_effective_potential_electrostatic_picmi.checksum (Failed) ``` I pushed [57e8e22](https://github.com/ECP-WarpX/WarpX/pull/5356/commits/57e8e22e3ebbb5dee3f51ff2c36b2eb3c94390bb)...

@ax3l @lucafedeli88 @RemiLehe CI is green now and the PR is ready for review.

Thanks, @roelof-groenewald. I renamed the variable to `skip_lev0_coarse_patch`, just to shorten the name as much as possible without missing any crucial component.