Edoardo Zoni

Results 177 comments of Edoardo Zoni

@lucafedeli88 @WeiqunZhang's suggestion seems good to me, what do you think?

Note that there is also https://github.com/BLAST-WarpX/warpx/pull/5828#discussion_r2087573096 that isn't just about docstrings. We already changed other names in this PR, e.g., `invc` and `invc2`, so we could change `ep0` too, as...

Discussed offline with @oshapoval, @jlvay and @RemiLehe: We will replace the current parameters, namely - `warpx.do_multi_J`, - `warpx.do_multi_J_n_depositions`, - `psatd.rho_in_time`, and - `psatd.J_in_time` with the single parameter `psatd.JRhom` which will...

@dpgrote The PR looks good to me in general. There is only a merge conflict to fix. Since this contains an API breaking change, personally I don't remember how we...

Just one more question, to prepare for more discussions later on. It's not clear to me if we reached consensus on the fact that this new syntax ``` rho =...

Before merging, please note that none of the GitHub Actions workflows ran on the last commit, not sure why. It may be worth amending the commit to re-trigger the CI...

~On another note, two big PRs will be merged soon:~ ~- #3630~ ~- #5682~ ~Since those PRs introduce new CI tests, I would recommend that we merge `development` here, after...

@roelof-groenewald Sorry, I meant to post my message on #5820. Too many PRs opened in the browser...

If I'm not mistaken, it looks like the code changes implemented here should be migrated to `Source/FieldSolver/ElectrostaticSolvers/PoissonBoundaryHandler.cpp` (as the file `Source/FieldSolver/ElectrostaticSolver.cpp` has been moved or deleted).