Edoardo Zoni
Edoardo Zoni
@roelof-groenewald I think I resolved the conflicts. This should be ready to review again.
@atmyers I renamed the WarpX functions `AddIntComp` and `AddRealComp`, defined in `Source/Particles/NamedComponentParticleContainer.H`, as `NewIntComp` and `NewRealComp`, respectively, in order to avoid confusion with the AMReX functions of the same name,...
@atmyers Also, in WarpX's newly renamed functions `NewIntComp` and `NewRealComp` we call the AMReX functions `AddIntComp` and `AddRealComp` by passing only the boolean `comm` flag. I have not changed this...
Discussed on Slack: @atmyers will open a PR to call the new AMReX functions and remove `NamedComponentParticleContainer` from WarpX.
Rebase after #5399 to pass the `macOS / AppleClang` check.
@dpgrote I just disabled auto-merge here, please feel free to review and suggest further changes as in #5401 if you see that something is missing. Here we decided to rename...
PR #5696 is an example of such a workflow.
Cc: @lucafedeli88 @dpgrote
@JohanKoelsenDeWit Let's try to start simple and add complexity step by step. I ping @WeiqunZhang here, who might be able to guide the installation more efficiently than me. The first...
Thanks, @JohanKoelsenDeWit. We can definitely skip the `--fresh` option, but regardless of that we do require minimum version 3.24 indeed: https://github.com/ECP-WarpX/WarpX/blob/dc68659c1b2d6a689f4b602bddd42f9099fb5928/CMakeLists.txt#L3 I do recommend inquiring with the MARCONI support and...