StéphaneDucasse

Results 1102 comments of StéphaneDucasse

I imagine that we should have a specific color theme for the text

Nice to have more tests.

@hernanmd I relaunched the build because there were refactoring failing tests ``` [MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [osx-64...

What a pain this issue. We still have these failing tests ``` osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1) | 4.8 sec | 4 -- | -- | -- unix-64...

We still have the following tests breaking ``` [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [osx-64...

Still some related tests are broken ``` [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/) [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/) [osx-64 / Tests-osx-64 /...

So we have the following tests breaking [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Core.Tests.RBClassTest.testHierarchyDefinesClassVariable](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/14/testReport/junit/MacOSX64.Refactoring.Core.Tests/RBClassTest/osx_64___Tests_osx_64___testHierarchyDefinesClassVariable/) [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Core.Tests.RBClassTest.testSuperclassRedefines](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/14/testReport/junit/MacOSX64.Refactoring.Core.Tests/RBClassTest/osx_64___Tests_osx_64___testSuperclassRedefines/) [osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.ProperMethodCategorizationTest.testNoUncategorizedMethods](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/14/testReport/junit/MacOSX64.ReleaseTests/ProperMethodCategorizationTest/osx_64___Tests_osx_64___testNoUncategorizedMethods/) [unix-64 / Tests-unix-64 / Unix64.Refactoring.Core.Tests.RBClassTest.testHierarchyDefinesClassVariable](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/14/testReport/junit/Unix64.Refactoring.Core.Tests/RBClassTest/unix_64___Tests_unix_64___testHierarchyDefinesClassVariable/) [unix-64 / Tests-unix-64...

I rescued the tests and did another PR