pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Published 20 hours ago • verified publisher icon pharo-project

Add RB missing tests

Open hernanmd opened this issue 1 year ago • 11 comments

This PR addresses missing tests reported in #11337:

  • Add test for hierarchyDefinesClassVariable:
  • Add test for hierarchyDefinesPoolDictionary:
  • Add test for superclassRedefines:
  • Marked wrong critiques for RefactoringData

hernanmd avatar Jul 18 '24 10:07 hernanmd

failing test: testNoUnusedClassVariablesLeft

MarcusDenker avatar Jul 18 '24 12:07 MarcusDenker

Nice to have more tests.

Ducasse avatar Jul 18 '24 19:07 Ducasse

@hernanmd I relaunched the build because there were refactoring failing tests

[MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[osx-64 / Tests-osx-64 / MacOSX64.NewTools.FileBrowser.Tests.StOpenFilePresenterTest.testSelectedEntriesMultipleSelection](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.NewTools.FileBrowser.Tests/StOpenFilePresenterTest/osx_64___Tests_osx_64___testSelectedEntriesMultipleSelection/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.ReleaseTests/NoUnusedVariablesLeftTest/osx_64___Tests_osx_64___testNoUnusedClassVariablesLeft/)
[osx-64 / Tests-osx-64 / MacOSX64.System.Dependencies.Tests.SystemDependenciesTest.testExternalUIDependencies](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.System.Dependencies.Tests/SystemDependenciesTest/osx_64___Tests_osx_64___testExternalUIDependencies/)
[unix-64 / Tests-unix-64 / Unix64.NewTools.FileBrowser.Tests.StOpenFilePresenterTest.testSelectedEntriesMultipleSelection](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.NewTools.FileBrowser.Tests/StOpenFilePresenterTest/unix_64___Tests_unix_64___testSelectedEntriesMultipleSelection/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRemoveClassDriverTest/unix_64___Tests_unix_64___testGoodPathRemovingNonEmptyLeaf/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.ReleaseTests/NoUnusedVariablesLeftTest/unix_64___Tests_unix_64___testNoUnusedClassVariablesLeft/)

Ducasse avatar Jul 21 '24 09:07 Ducasse

@hernanmd I relaunched the build because there were refactoring failing tests

[MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[osx-64 / Tests-osx-64 / MacOSX64.NewTools.FileBrowser.Tests.StOpenFilePresenterTest.testSelectedEntriesMultipleSelection](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.NewTools.FileBrowser.Tests/StOpenFilePresenterTest/osx_64___Tests_osx_64___testSelectedEntriesMultipleSelection/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.ReleaseTests/NoUnusedVariablesLeftTest/osx_64___Tests_osx_64___testNoUnusedClassVariablesLeft/)
[osx-64 / Tests-osx-64 / MacOSX64.System.Dependencies.Tests.SystemDependenciesTest.testExternalUIDependencies](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/MacOSX64.System.Dependencies.Tests/SystemDependenciesTest/osx_64___Tests_osx_64___testExternalUIDependencies/)
[unix-64 / Tests-unix-64 / Unix64.NewTools.FileBrowser.Tests.StOpenFilePresenterTest.testSelectedEntriesMultipleSelection](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.NewTools.FileBrowser.Tests/StOpenFilePresenterTest/unix_64___Tests_unix_64___testSelectedEntriesMultipleSelection/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRemoveClassDriverTest/unix_64___Tests_unix_64___testGoodPathRemovingNonEmptyLeaf/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/testReport/junit/Unix64.ReleaseTests/NoUnusedVariablesLeftTest/unix_64___Tests_unix_64___testNoUnusedClassVariablesLeft/)

Yes. I've seen these. Yesterday I marked them as wrong in the manifest, but for some reason, they're still being checked. I'll check it tomorrow.

hernanmd avatar Jul 21 '24 19:07 hernanmd

Tx!

Ducasse avatar Jul 22 '24 16:07 Ducasse

What a pain this issue. We still have these failing tests

<head></head>
osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1) | 4.8 sec | 4
-- | -- | --
unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1) | 7.5 sec | 4
windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1) | 9.4 sec | 4
osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf | 0.22 sec | 6
osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess | 5.9 sec | 6
osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess | 5.8 sec | 6
osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft | 1.3 sec | 6
unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf | 0.32 sec | 6
unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess | 6.6 sec | 6
unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess | 6.4 sec | 6
unix-64 / Tests-unix-64 / Unix64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft | 3.2 sec | 6
windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf | 0.38 sec | 6
windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess | 7 sec | 6
windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess | 6.9 sec | 6
windows-64 / Tests-windows-64 / Windows64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft

[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)	4.8 sec	[4](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/)
 [unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)	7.5 sec	[4](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/)
 [windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)	9.4 sec	[4](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/3/)
 [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/)	0.22 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testInvalidNameFollowedByAValidNameExpectSuccess/)	5.9 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testValidNameExpectSuccess/)	5.8 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/MacOSX64.ReleaseTests/NoUnusedVariablesLeftTest/osx_64___Tests_osx_64___testNoUnusedClassVariablesLeft/)	1.3 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Unix64.Refactoring.UI.Tests/ReRemoveClassDriverTest/unix_64___Tests_unix_64___testGoodPathRemovingNonEmptyLeaf/)	0.32 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testInvalidNameFollowedByAValidNameExpectSuccess/)	6.6 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testValidNameExpectSuccess/)	6.4 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [unix-64 / Tests-unix-64 / Unix64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Unix64.ReleaseTests/NoUnusedVariablesLeftTest/unix_64___Tests_unix_64___testNoUnusedClassVariablesLeft/)	3.2 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Windows64.Refactoring.UI.Tests/ReRemoveClassDriverTest/windows_64___Tests_windows_64___testGoodPathRemovingNonEmptyLeaf/)	0.38 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Windows64.Refactoring.UI.Tests/ReRenameMethodDriverTest/windows_64___Tests_windows_64___testInvalidNameFollowedByAValidNameExpectSuccess/)	7 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Windows64.Refactoring.UI.Tests/ReRenameMethodDriverTest/windows_64___Tests_windows_64___testValidNameExpectSuccess/)	6.9 sec	[6](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/1/)
 [windows-64 / Tests-windows-64 / Windows64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/6/testReport/Windows64.ReleaseTests/NoUnusedVariablesLeftTest/windows_64___Tests_windows_64___testNoUnusedClassVariablesLeft/)

Ducasse avatar Jul 25 '24 06:07 Ducasse

Errors seems related

jecisc avatar Jul 25 '24 14:07 jecisc

Errors seems related

This PR would need #16953 first

hernanmd avatar Jul 30 '24 21:07 hernanmd

We still have the following tests breaking

[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/windows_64___Tests_windows_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/MacOSX64.ReleaseTests/NoUnusedVariablesLeftTest/osx_64___Tests_osx_64___testNoUnusedClassVariablesLeft/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.Refactoring.UI.Tests/ReRemoveClassDriverTest/unix_64___Tests_unix_64___testGoodPathRemovingNonEmptyLeaf/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Unix64.ReleaseTests/NoUnusedVariablesLeftTest/unix_64___Tests_unix_64___testNoUnusedClassVariablesLeft/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.Refactoring.UI.Tests/ReRemoveClassDriverTest/windows_64___Tests_windows_64___testGoodPathRemovingNonEmptyLeaf/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.Refactoring.UI.Tests/ReRenameMethodDriverTest/windows_64___Tests_windows_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[windows-64 / Tests-windows-64 / Windows64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.Refactoring.UI.Tests/ReRenameMethodDriverTest/windows_64___Tests_windows_64___testValidNameExpectSuccess/)
[windows-64 / Tests-windows-64 / Windows64.ReleaseTests.NoUnusedVariablesLeftTest.testNoUnusedClassVariablesLeft](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/9/testReport/junit/Windows64.ReleaseTests/NoUnusedVariablesLeftTest/windows_64___Tests_windows_64___testNoUnusedClassVariablesLeft/)

Ducasse avatar Aug 01 '24 08:08 Ducasse

Still some related tests are broken

[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/osx_64___Tests_osx_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBRemoveSenderMethodParametrizedTest.testRemoveSenderIntoCascadedMessage(#rbClass->RBRemoveSenderRefactoring #constructor->#remove:inMethod:forClass: #index->1)](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/Unix64.Refactoring.Transformations.Tests/RBRemoveSenderMethodParametrizedTest/unix_64___Tests_unix_64___testRemoveSenderIntoCascadedMessage__rbClass__RBRemoveSenderRefactoring__constructor___remove_inMethod_forClass___index__1_/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRemoveClassDriverTest/osx_64___Tests_osx_64___testGoodPathRemovingNonEmptyLeaf/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[osx-64 / Tests-osx-64 / MacOSX64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/MacOSX64.Refactoring.UI.Tests/ReRenameMethodDriverTest/osx_64___Tests_osx_64___testValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRemoveClassDriverTest.testGoodPathRemovingNonEmptyLeaf](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/Unix64.Refactoring.UI.Tests/ReRemoveClassDriverTest/unix_64___Tests_unix_64___testGoodPathRemovingNonEmptyLeaf/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testInvalidNameFollowedByAValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testInvalidNameFollowedByAValidNameExpectSuccess/)
[unix-64 / Tests-unix-64 / Unix64.Refactoring.UI.Tests.ReRenameMethodDriverTest.testValidNameExpectSuccess](https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/PR-16917/12/testReport/junit/Unix64.Refactoring.UI.Tests/ReRenameMethodDriverTest/unix_64___Tests_unix_64___testValidNameExpectSuccess/)

Ducasse avatar Aug 02 '24 06:08 Ducasse

So we have the following tests breaking

osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Core.Tests.RBClassTest.testHierarchyDefinesClassVariable osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Core.Tests.RBClassTest.testSuperclassRedefines osx-64 / Tests-osx-64 / MacOSX64.ReleaseTests.ProperMethodCategorizationTest.testNoUncategorizedMethods unix-64 / Tests-unix-64 / Unix64.Refactoring.Core.Tests.RBClassTest.testHierarchyDefinesClassVariable unix-64 / Tests-unix-64 / Unix64.Refactoring.Core.Tests.RBClassTest.testSuperclassRedefines unix-64 / Tests-unix-64 / Unix64.ReleaseTests.ProperMethodCategorizationTest.testNoUncategorizedMethods unix-64 / Tests-unix-64 / Unix64.UnifiedFFI.Tests.LibTTYTest.test2 windows-64 / Tests-windows-64 / Windows64.Refactoring.Core.Tests.RBClassTest.testHierarchyDefinesClassVariable windows-64 / Tests-windows-64 / Windows64.Refactoring.Core.Tests.RBClassTest.testSuperclassRedefines windows-64 / Tests-windows-64 / Windows64.ReleaseTests.ProperMethodCategorizationTest.testNoUncategorizedMethods Show all failed tests >>>

Ducasse avatar Oct 05 '24 15:10 Ducasse

I rescued the tests and did another PR

Ducasse avatar Feb 03 '25 14:02 Ducasse