StéphaneDucasse comments

Results 1102 comments of


                                            StéphaneDucasse

The first you use "doit" in the Playground it takes around 5 seconds

I get the same with Spotter.

Tests Runner walkback - #canBeBrowsed sent to nil

Thanks! Clearly a lack of tests.

[RB] RBRemoveAllSenders improvements: name is bad, semantics is fuzzy

We should check first extractRefactoring in particular the extractMethodTransformation Then the inlineRefactoring and its transformation.

[RB] checkMethodName: aString in: aClass has an extra unused argument

issue still there in P13 and can be done easily.

[RB] checkMethodName: aString in: aClass has an extra unused argument

fixed!

[RB] About menu feedback

So we should discuss with balsa.

[RB]: Move remove class transformation to Driver

Done now should do a post integration phase

[RB]: whichSelectorsReferToClassVariable: does not work when a subclass accesses a class variable from the superclass

And now my code is ``` accessingSharedVariable ^ Shared1 ``` So the variable is used.

[RB]: whichSelectorsReferToClassVariable: does not work when a subclass accesses a class variable from the superclass

To me RBClass>>bindingOf: aString is wrong ``` bindingOf: aString ^self realClass classPool associationAt: aString asSymbol ifAbsent: [self realClass classPool associationAt: aString asString ifAbsent: [nil]] ``` Because it does not look...

[RB]: whichSelectorsReferToClassVariable: does not work when a subclass accesses a class variable from the superclass

``` whichSelectorsReferToClassVariable: aString | selectors | selectors := Set new. newMethods ifNotNil: [ newMethods do: [ :each | (each refersToVariable: aString) ifTrue: [ selectors add: each selector ] ] ]....