Dominique Rau

Needs external files access permission even if not used

1

This should be only optional. Interested in PR?

Move encoding to native

11

Using utf8 with hermes was too slow, so I've moved encoding to native. I'll be testing this for the next two weeks and report issues here. The changes are quite...

Split out react-native to support other css-in-js frameworks

1

I really like this project and would like to use it for web-projects as well (without react-native-web). Would you consider a PR splitting up the file in a way we...

Would it be possible to add a .bound variant for actionAsync?

Postinstall copy of readme should be removed

2

This will run on `yarn install` for consumers of this library. Instead of `postinstall` we should use `prepack`. https://github.com/callstack/react-native-slider/blob/8619daf7518c24ff7fdcfced73111d7dd856f727/package/package.json#L22 I'm getting: ``` error PROJECT_DIR/node_modules/@react-native-community/slider: Command failed. Exit code: 254 Command:...

feat(alert): use support library for alert dialog

15

## Summary Instead of using the AlertDialog from the android library we use the AlertDialog from the support library to render dialogs properly on Lollipop phones. ## Changelog [Android] [Fixed]...

fix(RCTUITextField): apply workaround for UIKit bug that works for multiline to singleline

4

## Summary See https://github.com/facebook/react-native/commit/e020576b34fb6ca6d3f9fe38916844b78a45c0e3 for rational. This bug in UIKit does apply for all UITextInput views. So this PR copies over the fix from multiline-view to singleline-view. ## Changelog [iOS]...

feat(waiting): add error handling for errors while waiting

3

While using a custom cert pinnner calling `completion(.failed(error))` will update the state with state `waiting` passing the cert error. In this case we also should call the error handler.

Exporting XLIFF with duplicate keys in different namespaces mixes them up

2

We have different namespaces, but within the namespaces we have the same key multiple times. E.g. `alert.title` could be `"attention"` in namespace `a` and `"warning"` in namespace `b`. When exporting...

taiSeconds should probably be long

1

taiSeconds are 40bits => 5 bytes which means it won't fit into 4 byte int https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library/blob/1e71dabe7cd0a1047db4b662d2af41fb5e9e3584/mesh/src/main/java/no/nordicsemi/android/mesh/transport/TimeStatus.java#L33 which means the BitReader should also parse to long