Android-nRF-Mesh-Library icon indicating copy to clipboard operation
Android-nRF-Mesh-Library copied to clipboard

Published 20 hours ago • verified publisher icon NordicSemiconductor

taiSeconds should probably be long

Open DomiR opened this issue 1 year ago • 1 comments

taiSeconds are 40bits => 5 bytes which means it won't fit into 4 byte int

https://github.com/NordicSemiconductor/Android-nRF-Mesh-Library/blob/1e71dabe7cd0a1047db4b662d2af41fb5e9e3584/mesh/src/main/java/no/nordicsemi/android/mesh/transport/TimeStatus.java#L33

which means the BitReader should also parse to long

DomiR avatar Aug 10 '23 21:08 DomiR

@DomiR sorry for the delayed reply. Thanks for spotting this. I'll try to find some time to fix this. If you have done already, please do send us a PR :)

roshanrajaratnam avatar Aug 30 '23 08:08 roshanrajaratnam