Dario Nieuwenhuis

The modem firmware tells us the list length for rx. It would be better to just use it, instead of validating it equals 16 or 32. This is better because...

Yes, we really should change it. There's two lists: - For TX (ie application -> modem), we decide the length, we allocate it, we tell the modem the length and...

New version is looking good! :) Seems something went wrong while merging/rebasing, there's now 300 commits in the PR. Could you fix that? I'd also suggest squashing it down to...

Thanks for the PR! I've rebased it and removed unrelated things to the main point of the PR (nrf9151) - Removed the attach timeout. In async Rust it's generally idiomatic...

is this to support flashes where you query the size by doing e.g. an SPI operation which requires async? I think in general it'd be better to read it in...

https://github.com/embassy-rs/embassy/pull/1242

it's not a bug, it's just not implemented. PRs would be welcome.

lgtm, but this is a breaking change of `embassy-usb-driver` which is somewhat disruptive (needs releasing updates for all of embassy-usb, all crates that use it, and all hal crates), so...

@kat-perez now that #4383 is merged, could you change this to be a "trace" bool field in Metadata?

Please do not add enums for "0 = disabled, 1 = enabled", they're redundant.