Dario Nieuwenhuis
Dario Nieuwenhuis
Yes, it's forced by design. :( > Would it be difficult to add a variant to the Operation enum that accepts a closure only if a feature flag is set?...
> Would you ever consider an additional trait that adds the closure design as well? > That way the HAL implementers that can support it are able to expose it...
> What if I have two devices on a bus that need the closure approach, both libraries may have bus sharing implementations that don't work with each other (leading to...
> The trait you proposed isn't in terms of SPI though, it's in terms of the display protocol, which should be abstracted away. It's somewhat common to do protocol-specific "bus...
i'm personally 50/50 on this. The tradeoffs are subtle and i'm not sure which side of them is the best. So I won't merge this myself but I'm OK with...
it should be fine to overlap them. However, I wonder if we should instead do a single "peripheral" for all these calibration values? Making one for each random calibration value...
it's abandoned, feel free to pick it up
closing since this is an empty skeleton.
> However, in embedded-hal, the SPI generics are bound to Word, such as SpiBus. For SPI structs that own the implementation of this trait, it's not possible to flexibly change...