Dario Nieuwenhuis

with latest git master including #2802?

I cannot reproduce this ``` git[dirbaio@mercury ~]$ git clone https://github.com/rust-embedded/embedded-hal Cloning into 'embedded-hal'... remote: Enumerating objects: 4476, done. remote: Counting objects: 100% (946/946), done. remote: Compressing objects: 100% (221/221), done....

Same, it build fine for me. Both with and without the `[patch.crates-io]`.

BufferedUart / RingbufferedUart do exactly that, `.read()` immediately returns the available data without having to wait for the buffer to fill up.

can you fix ci?

in smoltcp the socket needs to be owned by the SocketSet. Your own code only owns the handle, every time you need to do something with the socket you have...

> But to read or write you need a mutable reference to the socket. So you must have mutable reference to the SocketSet to read or write. That way I'm...

the original design of DHCP was to provide the raw bytes in `Config::packet`, so the user can parse the options they're interested in from there. The reason for this is...

Fix looks good to me. Can you add a test for it? i.e. a test that would previously fail and now works with your fix.

I was looking through this in more detail to add more tests, and i'm not convinced it's correct anymore. `set_for_retransmit()` is called on egress when we send more data. Therefore...