Dimitri Papadopoulos Orfanos

Results 835 comments of Dimitri Papadopoulos Orfanos

Thank you @charris. I will try to fix the linter failures. Curiously, they don't occur when running ruff from directly from the command line. Perhaps a configuration issue.

Please provide background information in the commit message. Why should the confg file be `%I` instead of `%I.conf`?

@dsl400 Why do you want to remove the `.conf` file extension?

The file name is generated from `/etc/openfortivpn/%I.conf`, but I don't see why the value of `%I` would be `config` in your case. For instantiated units, `%i` is the string between...

I cannot recall myself. I only know this pull request cannot be merged without any form of explanation: it breaks existing behaviour for the sake of an obscure use case...

While the child class does not **have** to call `super.__init__()`, it is usually expected to. In this specific case, `LoggingStore` inherits `Store`. If possible, `LoggingStore.__init__` should call `Store.__init__`. That does...

https://www.encodeproject.org/profiles/biosample_type appears to be back online.

No functionality changes. The rationale is that upstream have changed bzero() to memset() in their latest version 1.4. The header claims that the following changes have been applied to upstream...

It just occurred to me that I should also update `md5.h` from 1.1 to 1.3, for consistency: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/md5.h.diff?r1=1.1&r2=1.3&f=h