Dimitri Papadopoulos Orfanos

Results 835 comments of Dimitri Papadopoulos Orfanos

Both [build](https://github.com/ofek/coincurve/blob/master/.github/workflows/build.yml) and [shared_build](https://github.com/ofek/coincurve/blob/master/.github/workflows/verify_shared_build.yml) fail when building for macOS on the legacy Intel x86-64 architecture. Changing `macos-13` → `macos-14` should not be necessary if `macos-13` worked in the past: it...

Indeed [PEP 639](https://peps.python.org/pep-0639/) support requires Setuptools [77](https://setuptools.pypa.io/en/stable/history.html#v77-0-0). However, that's not a problem because users should upgrade to the latest version any way. From [Installing Packages](https://packaging.python.org/en/latest/tutorials/installing-packages/): > ### [Ensure pip, setuptools,...

If `pip install` fetches the latest `setuptools` at execution time, it's not an issue for end-users, is it? Am I right that `setuptools >= 77` applies to packaging time? If...

I'm not sure it must be dropped. Isn't `setuptools >= 77` required when packaging (typically `python -m build`)

Uncommenting the SI units validation code would fix this LGTM.com recommendation: https://lgtm.com/projects/g/bids-standard/bids-validator/snapshot/18d01f82b84c4f67c48922e13928940176011ff4/files/bids-validator/validators/tsv/tsv.js?sort=name&dir=ASC&mode=heatmap#x247409e34f5d77de:1 https://github.com/bids-standard/bids-validator/blob/abb700c79b6d79683598a394aea5e0573b33412b/bids-validator/validators/tsv/tsv.js#L309-L336

I have created a PR to uncomment the SI units validation code. It's been sitting unused for a long time. Does it need some overhauling or more testing?

One problem is `µ` instead of `u` for [micro](https://www.wikiwand.com/en/Micro-) (actually both `µ` and `u` are valid for backwards compatibility): https://github.com/bids-standard/bids-validator/blob/abb700c79b6d79683598a394aea5e0573b33412b/bids-validator/utils/unit.js#L92

Another one is `Ω` instead of `Ohm` (again both `Ω` and `Ohm` are valid for backwards compatibility): https://github.com/bids-standard/bids-validator/blob/abb700c79b6d79683598a394aea5e0573b33412b/bids-validator/utils/unit.js#L37

I've changed to `macos-15-intel` or `macos-latest` instead. Intel runners will eventually disappear any way. From [Notice of macOS x86_64 (Intel) architecture deprecation](https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/#notice-of-macos-x86_64-intel-architecture-deprecation): > Apple has discontinued support for the x86_64...

For some reason, `macos-latest` jobs fail. I am thinking of using `macos-14` instead, and creating an issue for `macos-15`.