[INFRA] Do check for being a pull request not at job level

[yarikoptic]

Since this way it keeps it "grey" on PRs, which causes all other matrix runs and workflows to be expanded and thus requiring more mental cycles to understand that it is actually all good.

This way it should be collapsed. This commit sits on top of

• https://github.com/bids-standard/bids-specification/pull/2030
• #2033

to ensure no other workflows fail ATMSince this way it keeps it "grey" on PRs, which causes all other matrix runs and workflows to be expanded and thus requiring more mental cycles to understand that it is actually all good.

Relevant changes are only to the workflow file

With this we are getting

instead of

of https://github.com/bids-standard/bids-specification/pull/2035 ATM

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 82.71%. Comparing base (04faf74) to head (565febc). :warning: Report is 191 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2032   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[yarikoptic]

with my luck I do get a link fail ATM and it seems legit site down

URL        `https://www.encodeproject.org/profiles/biosample_type'
Name       `ENCODE Biosample Type'
Parent URL file:///home/circleci/project/site/modality-agnostic-files.html, line 2210, col 31
Real URL   https://www.encodeproject.org/profiles/biosample_type
Check time 60.250 seconds
Result     Error: ReadTimeout: HTTPSConnectionPool(host='www.encodeproject.org', port=443): Read timed out. (read timeout=60)

filed

• https://github.com/ENCODE-DCC/encoded/issues/4441

[DimitriPapadopoulos]

https://www.encodeproject.org/profiles/biosample_type appears to be back online.

[effigies]

I've approved this on the grounds that it's not a big deal and it doesn't cause problems, but I also have not experienced the confusion that this addresses.

I would appreciate it if a second approval comes with a concurrence that this actually solves a problem.

[yarikoptic]

FWIW, I extended original description with an example/comparison .

[effigies]

@yarikoptic This is what I'm seeing:

[yarikoptic]

interesting... for me it has that "Hide all checks" which if I click, would collapse it, but by default they are visible. The same in Brave (prior was one Chromium).

[effigies]

I still don't see that in either Firefox or Chromium. I'm going to interpret the lack of additional reviews as a sign others aren't having this problem and close. (I did update this so that if anybody wants to reopen it, it will be less out-of-date.)