Hannes Karppila
Hannes Karppila
Right, we have to add that to the Makefile.toml as well. Implemented in https://github.com/FuelLabs/fuel-core/pull/1508
One solution might be to have `ci` feature, and then have `#[cfg_attr(feature = "ci", deny(warnings)]`. Then just add `--feature ci` for CI checks.
The code itself looks good to me. Can you post the results for this so we can compare to old benchmark results?
It's [the cURL example](https://github.com/FuelLabs/fuel-core?tab=readme-ov-file#curl-example)
Fix merged upstream [here](https://github.com/bytecodealliance/wasmtime/pull/8049), just waiting for the update to propagate.
I was unable to find this dependency anywhere using `cargo tree`. Maybe this has already been fixed?
I think it might be best to provide separate functions for all four cases. Hoping to look into this sometime next week.
Mostly addressed in https://github.com/FuelLabs/fuel-vm/pull/729 From the original issue there's still: > * Limit leaves_count to 2^63 for push and load operations Which seems like a non-issue, as a it's physically...
Just to elaborate on this: there are `checked_*`, `overflowing_*`, `saturating_*` and multiple other variants. The appropriate operation should be used. A comment (e.g. spec link) on why a specific variant...
Here is a rust implementation I wrote some time ago: https://crates.io/crates/wsl. Easy to either depend on, or just copy the code to this project.