Hannes Karppila
Hannes Karppila
This is not a vm issue, the instruction that's supposed to revert is getting optimized away. Likely the compiler doesn't consider panic-on-invalid-input side effect. Not sure if the compiler behavior...
See https://github.com/FuelLabs/sway/pull/6452#issuecomment-2306881388 for a reproduction and output analysis.
> I know it's bikeshedding but can we call it something other than "blob"? It evokes either object based storage or proprietary binaries in kernel land. What this really is...
> @Dentosal should this PR also include the changes to the LDC opcode? Yes. They were not originally included as it was unclear whether we would have them in LDC...
The feature-flag protection is not extended to all things here, for instance the `Input::InputV2` variant isn't covered. I'm not sure how much issue this actually is, but it's already a...
Calling it incorrect is a bit weird; `Bytes64` is assumed to be without the tag byte and not in sec1 format.
This is really hard to do, as the floating point approximation method used in the u64 implementation cannot be used with wider types. We could do binary search using rougher...
> IS this a viable approach: creating a new output/input type for the `DataCoin`? Or should we just add an `Option`of data to `Coin`? > > Also, `Output` isn't `Clone`...
With these optimizations enalbed, it's possible to hit a pre-existing bug which causes compiler panic. The `should_fail/arith_overflow/u64_mul_overflow` test from (`cargo run --locked --bin test -- --locked --release`) hits this. The...
> What is the state of this PR? Also, do we have any benchmarks that shows how it improves the size of contracts? OR does it requires re-work of STD...