Hannes Karppila

Results 71 comments of Hannes Karppila

Some parts of the code just cannot work with variants they don't know about. For instance this part here https://github.com/FuelLabs/fuel-core/blob/b442485050b7668f079b7ed6f66b4c3d681ffb64/crates/services/txpool/src/containers/dependency.rs#L159 @MitchTurner any ideas on how to handle this gracefully?

Blocked by https://github.com/grafana/pyroscope-rs/issues/139

Tests fail in CI due to a timeout. Cannot reproduce locally. Investigating.

One of the test cases seems flakey, looking into that one

Mostly implemented in https://github.com/FuelLabs/fuel-vm/pull/684, although we still need a follow-up for `fuel-core` after that.

Migrating to https://github.com/FuelLabs/fuel-subgraph/pull/8

Should we use `#[non_exhaustive]` for the version enum? This way users of the type must handle the cases where they're not aware of the new values yet.

Design notes from my discussion with @xgreenx * The PoA key will be used tio sign the blobs * I'll create a script to read posted blobs from the sequencer

Migrated to https://github.com/FuelLabs/fuel-subgraph

We already seem to do this in our ci, so the lints in code can just be removed https://github.com/FuelLabs/fuel-core/blob/e940d1dad4c186f7cd70547d17b0ecb087e1e0e4/.github/workflows/ci.yml#L21