fuel-core icon indicating copy to clipboard operation
fuel-core copied to clipboard

Decrease peer reputation on request timeouts and decode errors

Open Dentosal opened this issue 2 years ago • 2 comments

Closes #1345. Closes #1346 Closes #1350.

This PR stops discarding request errors from libp2p, and instead returns them to the sender of the request. Also penalizes peers for sending invalid responses or for not replying at all.

Making penalty configurable should be a follow-up PR, as there are other penalties that should be configurable as well

TODO:

  • [x] Make timeout configutable: Already seems to be case on master branch
  • [x] Add tests
  • [x] Fix current tests that for some reason don't terminate

Dentosal avatar Dec 23 '23 01:12 Dentosal

Tests fail in CI due to a timeout. Cannot reproduce locally. Investigating.

Dentosal avatar Jan 09 '24 13:01 Dentosal

One of the test cases seems flakey, looking into that one

Dentosal avatar Jan 17 '24 15:01 Dentosal