Alice Ryhl

Results 336 comments of Alice Ryhl

Perhaps the most important part missing in being production-ready is an intention to support the project in the future. If someone reports an issue with this project, and we don't...

You would have to change several other parts of the codebase to elide that copy if it's possible at all.

A `Bytes` doesn't support seeking backwards, so it can't implement the trait.

> It’s easy to misuse if the stream variable is moved outside the stream, used inside `join!` or `select!` or `FuturesUnordered` etc I would want a better understanding of how...

Having this fail seems pretty confusing. I would certainly prefer a version where this works. Perhaps `yield_item` could do a `yield_now` if it is unable to yield it immediately? ```Rust...

I remember reproducing this when you posted it, but I can't reproduce it anymore. It's possible that it was fixed via #76. Can you test it again?

Adding this seems fine to me.

Can you show us line 61 of your main file (and the surrounding lines)?

@andrewbaxter If the reference count is equal to one (i.e. all other split `Bytes`/`BytesMut` have been dropped) when the `BytesMut` tries to reallocate, then it will reuse the entire allocation...

Indeed, a single allocation can contain any number of `BytesMut` and `Bytes` pointing into it as long as each `BytesMut` does not overlap with the range of any other handle.