Alice Ryhl

Results 336 comments of Alice Ryhl

Do we have a method that only succeeds if they can be joined without copying? If so, having both could make sense, and I do think that `unsplit` is a...

I think `unsplit` and `try_unsplit` are actually pretty good.

Seems reasonable enough to me.

Loom is slow. Tokio's CI setup takes more than an hour because that's how long time our slowest loom test takes. You could try to mess with `LOOM_MAX_PREEMPTIONS` to have...

Yes, but nobody has put in the work. Generally, loom will print the iteration number as it runs, so you can use that to see whether it has hung up....

Note that by using the `compact` method, it is possible to have values with keys greater than that length.

Ah, sorry, you are right, that doesn't happen. I had confused it with the [`DelayQueue`](https://github.com/tokio-rs/tokio/blob/master/tokio-util/src/time/delay_queue.rs).

I didn't see this comment when it was first posted, but it seems reasonable to me.

Thinking about this some more, I actually think it is better to keep it. Even though it never triggers in the current codebase, it makes the code more robust to...