Alice Ryhl

Results 336 comments of Alice Ryhl

We are unlikely to have a breaking release any time soon, so your PR would probably sit around for at least a year. Additionally, I don't really think there's any...

They can't just be renamed due to backwards compatibility. The most we could do is deprecate and `#[doc(hidden)]` it, adding an alternative.

There are lots of crates with `bytes` in the public api that don't reexport it. Is there any particular reason it is more important for mini-redis?

You say it is generally considered to be best practice, but I've never heard of it before, and I'm certainly not new to Rust. In any case, I think it's...

It would be very useful to know if this is a bug that has already been fixed in a newer version of bytes or not. You may be able to...

I'm not able to determine what the issue is from what's written here. It would require someone to sit down and spend a bunch of time debugging the issue. I...

Changing it to `listen` or `receiver` sounds reasonable to me. I do not think that `collect` and `gather` would be good names.

> We had contemplated receiver but thought for new users, coming from other languages, it might be mistaken as an instance (or some such concept) of `Receiver`, while from (weak/flawed)...

You could do `write!((&mut buf).writer(), "hello")`, still I do see the point.

No idea. It should be removed.