Alice Ryhl comments

Results 336 comments of


Alice Ryhl

Add feature to support platforms without atomic CAS

Sorry, I never got around to it. I'm happy to accept this feature, with the following changes: * We should document that this feature exists in the readme or `lib.rs`....

`Bytes::with_vtable` Can it be opened for external use

Closing as duplicate of #437.

Make `try_unsplit` method public

Just because it doesn't do that today doesn't mean it couldn't in the future. I don't really have the time to work through the vtable situation any time soon.

why so slow compared with redis?

Pipelining requires that you can start processing the next message before responding to the first. Mini-redis will not implement it.

fix: improve compatibility among test proc macros

So, to sum up, your proposal is that test macros should add `#[::core::prelude::v1::test]` at the end and only if the function doesn't already have the attribute?

Miri reports possible UB in `Body`

> I tested with `poll_fn` patched to be `Unpin` and can confirm it doesn't fix the miri issue. The `poll_fn` doesn't take ownership of any futures in the first place,...