Dani Guardiola
Dani Guardiola
PD: I think I broke codecov, help! :S
@kr1sp1n any comments? :)
LOL I edited the README just so that travis could re-run, as they canceled all the jobs yesterday due to [an incident](https://www.traviscistatus.com/incidents/c1s4dlyxd4lf) in their .org platform
Hi @kr1sp1n, did you have time to review the latest changes? I would like to move forward with the PR :)
To do: - [x] Fix [package.json directories](https://docs.npmjs.com/files/package.json#directories) - [x] Fix conflicts - [x] [Make auth features dryer?](https://codeclimate.com/github/DaniGuardiola/node-vault/issues?category%5B%5D=complexity&category%5B%5D=duplication&status%5B%5D=&status%5B%5D=open&status%5B%5D=confirmed&engine_name%5B%5D=structure&engine_name%5B%5D=duplication) - [ ] Add remaining documentation to [features](src/interface/features.js)
@kr1sp1n awesome! The PR is not as prio for my company as it was, so maybe we can add more features and functionality and further improve code, tests and documentation...
@kr1sp1n sounds good! Could you add me to the project as contributor so I can edit and move stuff around? :)
Sorry guys, I haven't had time and I guess @kr1sp1n hasn't either. I'll try to block some time at some point to make it happen, there's actually not much work...
Hey @kr1sp1n what do you say we set a datetime for a call one of these weekends and we get it done in two hours by working in sync? It...
@kr1sp1n gotcha, will see what I can do then. I still need you for the npm release!