Dani Guardiola

Results 263 comments of Dani Guardiola

[Removed `mustache`!](https://github.com/DaniGuardiola/node-vault/commit/82836f960e41e833a5791fc18738f36a0716d4e3) Yay! :) Thanks @StarpTech for helping me with the idea. We can cross that off the list now, pending @kr1sp1n answer to my question.

Current tasks: - [x] Use ES6 syntax - [x] ~Provide packages for different Auth backends~ (won't do) - [x] Remove `mustache` - [x] ~Switch to `simple-get` instead of `request` +...

Could you guys do some code review?

So I found two problems with `simple-get`, check [the commit](https://github.com/DaniGuardiola/node-vault/commit/6ab8f98d0a27ee3ba852169cfee567938c9aed62) to see the diff and the extended description of the issue.

TL;DR: - No strictSSL support - Ports don't work??? Integration tests fail with `connect ECONNREFUSED 127.0.0.1:80` So unless we can find a lib that supports both things, we should keep...

https://www.npmjs.com/package/needle This could be an alternative, supports `rejectUnauthorized` which is basically what `strictSSL` did in the `request` module

It is not a slim package though, it might not be worth it if it's bigger or similar to `request + request-promise-native` in size / efficiency

Ideally, I would like to finish the last details and send another pull request to finish the whole refactor. After that my plan is to add a better authentication interface...

I just saw your 'Modernize' project on the repo. In this PR, the `use ES6 syntax` step is already done and the `provide better documentation` is on the way. I...

BTW I also think that the integration tests need a bit more stress, i.e. storing and retrieving values, changing configurations and testing if the changes where effective and so on.